https://issues.apache.org/ooo/show_bug.cgi?id=123862
--- Comment #22 from [email protected] --- (In reply to [email protected] from comment #21) > @j.nitschke: All patches are good so far, its a wonderful cleanup. Thanks > for working on it! Welcome > But with AOO 4.1 beta coming soon I'd like to wait with further integrations > until the release branch for AOO 4.1 has been split off. Yes, that's only reasonable. I try to work with great caution, but with the number of changes, errors get more likely. > Looking at these masses of emptiness-checks I thought that having another > method isNotEmpty() would improve the readability even more. My current regexp finds about 7500 potential replace candidates. I expect 1/5 false positives, leaves 6000 replacements. If half of these are checks for not empty, an other method for 3000 calls is a good idea. btw. is there a standard encoding for the codebase? I use eclipse with standard setting UTF-8 and sometimes the german comments get changed. It seems at least some files use ISO-8859-x encoding. I did a standard checkout and diff with svn command line tool on linux. I read the patches anyway so it's not a big deal to remove these changes but if you got a solution for this it's welcome. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
