https://issues.apache.org/ooo/show_bug.cgi?id=124372
--- Comment #4 from Andre <[email protected]> --- The change looks like a verbatim copy of Symphony code without making too many necessary adaptions. What was done is: - Change the content of the resource string RID_SVXSTR_SINGLENUM_DESCRIPTION_0 from "Number 1) 2) 3)" to "Number %NUMBERINGSAMPLE". - Create new class NumberingTypeMgr for accessing information related to numbering and bullets. Basically not a bad idea. - The NumberingTypeMgr is defined in the cryptically named file svx/source/sidebar/nbdtmg.cxx file with a code qualitiy that is hard to describe without resorting to unprintable characters like = Constructors that call Init() methods twice. = ImplLoad methods loading files with such descriptive names as 'standard.sya', 'standard.syb' and 'standard.syc'. = These files do not exist in our installation set. = UCB is used to read those non-existing files but checks file existence only when opening a file for writing. = The UCB stream is not tested by NumberingTypeMgr for validity but thankfully it reads one integer and tests it to be a valid version number, which it isn't. Reading is aborted before anything worse can happen. = The only places where those files would be written are triggered during the file reading, i.e. never. - The numbering style names are read in NumberingTypeMgr::Init where the (single occurance) of "%NUMBERINGSAMPLE" is replaced with a more meaningful content. - The idea behind this replacement in Init() seems to be to create descriptive strings for a modifyable set of numberings. Currently it is only applied to a fixed set of 8 default numberings. - The template numbering name is wrongly accessed via RID_SVXSTR_SINGLENUM_DESCRIPTIONS which is accidentally identical to RID_SVXSTR_SINGLENUM_DESCRIPTION_0. Using RID_SVXSTR_SINGLENUM_DESCRIPTION_0 would be the right way to do it. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
