https://bz.apache.org/ooo/show_bug.cgi?id=126668
orcmid <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #11 from orcmid <[email protected]> --- (In reply to Pathangi Jatinshravan from comment #10) > Using GetDouble() in the latest patch. I have also made the implementation > very flexible, and in the event that more arguments need to be accepted to > the bitwise operators in the future, it can very easily be done by just > changing the initial value of a constant variable. This is great work. I admire when folks work through the details of OpenFormula to get something right. I have one concern. Future-proofing is generally frowned on in the "simplest thing that can possibly work" view of things. Making a function more flexible in a way that has no way of being tested and is not exercised in the implementation creates potential maintenance hazards and extra footprint that provides no value at the moment. I am not requesting a change. However, I do not know what a future maintainer would make of the inessential parts of the implementation. It is unlikely that these operations will change in OpenFormula. If there is a change, we will not know in advance how it will impact the implementation and how compatibility/interoperabilty will be handled. It is always pleasing to generalize a solution at little (or even improved) cost. It is unclear to me that this very-specific operation is a good place to have done that. Again, this work is admirable. -- You are receiving this mail because: You are the assignee for the issue.
