https://bz.apache.org/ooo/show_bug.cgi?id=126787
Issue ID: 126787
Issue Type: PATCH
Summary: fix unit tests on windows
Product: Build Tools
Version: 4.2.0-dev
Hardware: All
OS: Windows, all
Status: CONFIRMED
Severity: Normal
Priority: P5 (lowest)
Component: code
Assignee: [email protected]
Reporter: [email protected]
Attachment #85248 review?
Flags:
Created attachment 85248
--> https://bz.apache.org/ooo/attachment.cgi?id=85248&action=edit
remove prewin.h and postwin.h in sal unittests
build process on windows is currently broken[1]
some unit tests in sal includes headers from tools which depends on sal
(circular dependencies)[2]
said headers are prewin.h and postwin.h which frame windows.h includes
I got no win build environment, but looking at the files I don't think they are
needed for the basic functionality sal (system abstraction layer) provides
would be happy to know if someone knows more about prewin and postwin
here a patch which removes the includes
if someone with a win build environment could test it or if no time let our
buildbot do the work. would be great
[1] https://ci.apache.org/builders/aoo-win7/builds/139
[2]
https://mail-archives.apache.org/mod_mbox/openoffice-dev/201512.mbox/%3C56804CDE.2020201%40ok.de%3E
note: all this is related to the work in Issue 125003 - Integrate GoogleTest
unit test framework for general usage in the build environment
--
You are receiving this mail because:
You are the assignee for the issue.
