https://bz.apache.org/ooo/show_bug.cgi?id=127044
Issue ID: 127044
Issue Type: DEFECT
Summary: Defects in the code
Product: Base
Version: 4.2.0-dev
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: Normal
Priority: P5 (lowest)
Component: code
Assignee: [email protected]
Reporter: [email protected]
We checked AOO by static analyzer AppChecker
(https://cnpo.ru/en/solutions/appchecker.php) and it found some possible
defects:
1) The left and the right parts of the binary expression are indetical
main/binaryurp/source/lessoperators.cxx, line 43
https://github.com/apache/openoffice/blob/c014b5f2b55cff8d4b0c952d5c16d62ecde09ca1/main/binaryurp/source/lessoperators.cxx#L43
if( rA.eTypeClass != rA.eTypeClass)
2) The left and the right parts of the binary expression are indetical
main/editeng/source/accessibility/AccessibleStaticTextBase.cxx line 362
https://github.com/apache/openoffice/blob/c014b5f2b55cff8d4b0c952d5c16d62ecde09ca1/main/editeng/source/accessibility/AccessibleStaticTextBase.cxx#L362
if( aTextSegment.SegmentStart != -1 &&
aTextSegment.SegmentStart != -1 )
3) The left and the right parts of the binary expression are indetical
main/editeng/source/uno/unotext.cxx, line 1943
https://github.com/apache/openoffice/blob/c014b5f2b55cff8d4b0c952d5c16d62ecde09ca1/main/editeng/source/uno/unotext.cxx#L1943
aRange.nStartPara = aRange.nStartPara;
4) The left and the right parts of the binary expression are indetical
main/sc/source/ui/unoobj/chart2uno.cxx line 640
https://github.com/apache/openoffice/blob/c014b5f2b55cff8d4b0c952d5c16d62ecde09ca1/main/sc/source/ui/unoobj/chart2uno.cxx#L640
if (nRow > 0 && nRow > 0)
5) The left and the right parts of the binary expression are indetical
main/svtools/source/dialogs/addresstemplate.cxx line 187
https://github.com/apache/openoffice/blob/c014b5f2b55cff8d4b0c952d5c16d62ecde09ca1/main/svtools/source/dialogs/addresstemplate.cxx#L187
for (;pFields != pFields; ++pFields)
6) The left and the right parts of the binary expression are indetical
main/tools/source/fsys/dirent.cxx, line 2670
https://github.com/apache/openoffice/blob/c014b5f2b55cff8d4b0c952d5c16d62ecde09ca1/main/tools/source/fsys/dirent.cxx#L2670
if ( pNewDir->eFlag == FSYS_FLAG_ABSROOT ||
pNewDir->eFlag == FSYS_FLAG_ABSROOT ... )
7) The left and the right parts of the binary expression are indetical
main/sc/source/core/tool/viewopti.cxx, line 107
https://github.com/apache/openoffice/blob/c014b5f2b55cff8d4b0c952d5c16d62ecde09ca1/main/sc/source/core/tool/viewopti.cxx#L107
return ( nFldDrawX == rCpy.nFldDrawX
&& nFldDrawX == rCpy.nFldDrawX ...)
8) Using bitwise operation to the boolean expression
main/framework/source/uielement/newmenucontroller.cxx, line 255
https://github.com/apache/openoffice/blob/c014b5f2b55cff8d4b0c952d5c16d62ecde09ca1/main/framework/source/uielement/newmenucontroller.cxx#L255
if ( nId & ( pPopupMenu->GetItemType( nId ) != MENUITEM_SEPARATOR ))
--
You are receiving this mail because:
You are the assignee for the issue.
