chetanmeh commented on a change in pull request #4559: Allow parameters to be
designated as init time properties
URL: https://github.com/apache/openwhisk/pull/4559#discussion_r315528235
##########
File path: docs/actions-new.md
##########
@@ -146,7 +146,8 @@ The initialization route is `/init`. It must accept a
`POST` request with a JSON
"name" : String,
"main" : String,
"code" : String,
- "binary": Boolean
+ "binary": Boolean,
+ "env": Map[String, JSON Value]
Review comment:
Ideally it should be a map of `<String, String>`. This would simplify the
implementation to just handle the value directly. Otherwise they would need to
stringify the value which may vary depending on runtime
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services