chetanmeh commented on a change in pull request #143: Export activation 
arguments to environment during initialization.
URL: 
https://github.com/apache/openwhisk-runtime-nodejs/pull/143#discussion_r316973368
 
 

 ##########
 File path: core/nodejsActionBase/src/service.js
 ##########
 @@ -160,6 +160,17 @@ function NodeActionService(config) {
     };
 
     function doInit(message) {
+        if (message.env && typeof message.env == 'object') {
+            Object.keys(message.env).forEach(k => {
 
 Review comment:
   Could have used [Object.entries][1] but looks like thats only from Nodejs 
7+. So used approach is more compatabile
   
   [1]: 
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to