rabbah commented on a change in pull request #4617: Add kind "unknown" to
fallback activations
URL: https://github.com/apache/openwhisk/pull/4617#discussion_r323088425
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
##########
@@ -263,7 +263,10 @@ class InvokerReactive(
}
val context = UserContext(msg.user)
- val activation = generateFallbackActivation(msg, response)
+ val activation = generateFallbackActivation(
+ msg,
+ response,
+ Parameters(WhiskActivation.kindAnnotation,
JsString(Exec.UNKNOWN)))
Review comment:
since it both cases of generating a fall back activation, the action is not
available, i favor not changing the function sigature and adding the unknow
annotation directly in `generateFallbackActivation` instead of at the two call
sites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
