rabbah commented on issue #4617: Add kind "unknown" to fallback activations
URL: https://github.com/apache/openwhisk/pull/4617#issuecomment-530438270
 
 
   > But all code locations that initially create the ActivationMessage know 
the action kind. So what about adding the action kind to the ActivationMessage 
when creating it?
   
   I think the current change is fine as is. In the two cases affected by the 
change in InvokerReactive. The first case: `get` failed in the second: 
`namespace` is blacklisted.
   
   What you're suggesting involves sending more information over the message 
bus. It's OK to do that but there is a cost to continuing to grown the 
activation message. Is it important enough to extend the ActivationMessage 
(serialization and deserialization costs) to cover two corner cases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to