BillZong commented on a change in pull request #4619: Add ansible deploy options
URL: https://github.com/apache/openwhisk/pull/4619#discussion_r324497597
##########
File path: ansible/roles/zookeeper/tasks/deploy.yml
##########
@@ -17,13 +17,6 @@
---
# This role will install Kafka with Zookeeper in group 'kafka' in the
environment inventory
-- name: "pull the zookeeper:{{ zookeeper.version }} image"
Review comment:
The retry here is meaningless, since errors happened here are fatal for
deployment.
e.g. image name/tag spelled wrong, wrong password for docker repo, network
timeout, etc.
All we should do is to fix them and re-deploy, instead of retrying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
