chetanmeh commented on a change in pull request #4625: emit additional metrics 
about invoker ContainerPool
URL: https://github.com/apache/openwhisk/pull/4625#discussion_r324750473
 
 

 ##########
 File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -316,6 +324,25 @@ class ContainerPool(childFactory: ActorRefFactory => 
ActorRef,
   def hasPoolSpaceFor[A](pool: Map[A, ContainerData], memory: ByteSize): 
Boolean = {
     memoryConsumptionOf(pool) + memory.toMB <= poolConfig.userMemory.toMB
   }
+
+  /**
+   * Log metrics about pool state (buffer size, buffer memory requirements, 
active number, active memory, prewarm number, prewarm memory)
+   */
+  def emitMetrics() = {
 
 Review comment:
   Nit: Better to make it private method. Else mark it return as `Unit`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to