sven-lange-last commented on a change in pull request #4624: Combines active 
ack and slot release when both are available.
URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326063425
 
 

 ##########
 File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
 ##########
 @@ -145,43 +146,34 @@ class InvokerReactive(
     new MessageFeed("activation", logging, consumer, maxPeek, 1.second, 
processActivationMessage)
   })
 
-  /** Sends an active-ack. */
   private val ack: InvokerReactive.ActiveAck = (tid: TransactionId,
                                                 activationResult: 
WhiskActivation,
                                                 blockingInvoke: Boolean,
                                                 controllerInstance: 
ControllerInstanceId,
                                                 userId: UUID,
-                                                isSlotFree: Boolean) => {
+                                                acknowledegment: 
AcknowledegmentMessage) => {
 
 Review comment:
   If the passed `acknowledegment` is a combined completion and result message 
or result message, it likely contains a `WhiskActivation` instance. So it 
duplicates the `activationResult` parameter which is only used to emit user 
metrics.
   
   Can't we drop the `activationResult` parameter and change the condition for 
sending user metrics? If the `acknowledegment.result` is non-empty and a 
`Right(WhiskActivation)`, we emit metrics - otherwise not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to