rabbah commented on a change in pull request #4624: Combines active ack and 
slot release when both are available.
URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326154490
 
 

 ##########
 File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerProxy.scala
 ##########
 @@ -628,8 +637,15 @@ class ContainerProxy(
     // completion message which frees a load balancer slot is sent after the 
active ack future
     // completes to ensure proper ordering.
     val sendResult = if (job.msg.blocking) {
-      activation.map(
-        sendActiveAck(tid, _, job.msg.blocking, job.msg.rootControllerIndex, 
job.msg.user.namespace.uuid, false))
+      activation.map { result =>
+        sendActiveAck(
+          tid,
+          result,
+          job.msg.blocking,
+          job.msg.rootControllerIndex,
+          job.msg.user.namespace.uuid,
+          ResultMessage(tid, result))
 
 Review comment:
   good idea - I won't do that here, as you suggest, can be done subsequently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to