rabbah commented on a change in pull request #4624: Combines active ack and 
slot release when both are available.
URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326158858
 
 

 ##########
 File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
 ##########
 @@ -145,43 +146,34 @@ class InvokerReactive(
     new MessageFeed("activation", logging, consumer, maxPeek, 1.second, 
processActivationMessage)
   })
 
-  /** Sends an active-ack. */
   private val ack: InvokerReactive.ActiveAck = (tid: TransactionId,
                                                 activationResult: 
WhiskActivation,
                                                 blockingInvoke: Boolean,
                                                 controllerInstance: 
ControllerInstanceId,
                                                 userId: UUID,
-                                                isSlotFree: Boolean) => {
+                                                acknowledegment: 
AcknowledegmentMessage) => {
 
 Review comment:
   yes - i considered doing that but because the current types allow for an 
`Either`, whereas all the call sites do know the activation, it would allow for 
a weakening should someone construct an ack with a Left where a Right is 
expected. I don't think there's a way to restrict the constructors (given they 
are case classes) without adding more types. So I think the current signature 
is tighter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to