sven-lange-last commented on a change in pull request #4628: Embedded Kafka 
support in OpenWhisk Standalone mode
URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326189887
 
 

 ##########
 File path: 
core/standalone/src/main/scala/org/apache/openwhisk/standalone/StandaloneOpenWhisk.scala
 ##########
 @@ -393,6 +417,42 @@ object StandaloneOpenWhisk extends SLF4JLogging {
     Await.result(g, 5.minutes)
   }
 
+  private def startKafka(workDir: File, dockerClient: StandaloneDockerClient, 
conf: Conf, kafkaUi: Boolean)(
+    implicit logging: Logging,
+    as: ActorSystem,
+    ec: ExecutionContext,
+    materializer: ActorMaterializer): (Int, Seq[ServiceContainer]) = {
+    val kafkaPort = getPort(conf.kafkaPort.toOption, 9092)
 
 Review comment:
   If we add a default value to the `kafkaPort` option, can probably solve this 
differently and not repeat the port number literal here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to