sven-lange-last commented on a change in pull request #4628: Embedded Kafka 
support in OpenWhisk Standalone mode
URL: https://github.com/apache/openwhisk/pull/4628#discussion_r326191971
 
 

 ##########
 File path: 
core/standalone/src/main/scala/org/apache/openwhisk/standalone/StandaloneOpenWhisk.scala
 ##########
 @@ -63,6 +64,25 @@ class Conf(arguments: Seq[String]) extends 
ScallopConf(arguments) {
   val apiGwPort = opt[Int](descr = "Api Gateway Port", default = Some(3234), 
noshort = true)
   val dataDir = opt[File](descr = "Directory used for storage", default = 
Some(StandaloneOpenWhisk.defaultWorkDir))
 
+  val kafka = opt[Boolean](descr = "Enable embedded Kafka support", noshort = 
true)
+  val kafkaUi = opt[Boolean](descr = "Enable Kafka UI", noshort = true)
+
+  val kafkaPort = opt[Int](
+    descr = "Kafka port. If not specified then 9092 or some random free port 
(if 9092 is busy) would be used",
+    noshort = true,
+    required = false)
 
 Review comment:
   I understand. Background of my proposal was that there is some duplication 
of the default ports. We have the port number 9092 for Kafka here AND in 
`startKafka()`. Wouldn't it make sense to define a `val defaultKafkaPort = 
9092` and use it to build the description string and in `startKafka()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to