rabbah opened a new issue #4636: Refactor active ack method signature to be an 
URL: https://github.com/apache/openwhisk/issues/4636
   >     */
   -  type ActiveAck = (TransactionId, WhiskActivation, Boolean, 
ControllerInstanceId, UUID, Boolean) => Future[Any]
   +  type ActiveAck =
   Minor observation (or Rant!) - I always struggle in IDE whenever I want to 
see impl of parameters which are specified as function signature instead of 
trait (like in ActiveAck). Here things are bit simpler as we specify a type 
alias which narrows down the search. Otherwise one need to check the whole call 
hierarchy to understand where is. the actual impl
   Having a trait enables easier checking of possible implementations to 
understand the code flow. This is pre existing stuff ... but may be later we 
refactor it and use a proper trait for such critical flows.
   From @chetanmeh in #4624.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to