jasonpet commented on issue #3863: missing null check during TestUtils 
initialization
URL: https://github.com/apache/openwhisk/issues/3863#issuecomment-541136467
 
 
   > in this method 
https://github.com/apache/incubator-openwhisk/blob/37ce9b86048dafb0f369a5a5b05caa0136a26ef4/tests/src/test/scala/common/WhiskProperties.java#L297
 there's a missing null check:
   > 
   > ```
   > public static File getVCAPServicesFile() {
   >         String vcapServices = 
whiskProperties.getProperty("vcap.services.file");
   >         if (vcapServices.startsWith(File.separator)) {
   >             return new File(vcapServices);
   >         } else {
   >             return 
WhiskProperties.getFileRelativeToWhiskHome(vcapServices);
   >         }
   >     }
   > ```
   > 
   > @jasonpet the `vcap` property does not appear to be used anymore in this 
repo:
   > 
   > 
https://github.com/apache/incubator-openwhisk/blob/9e5cec1f0e4b98c59e584d453b06a741be4a8c3b/tests/src/test/scala/common/TestUtils.java#L79
   > 
   > (per git blame 
[f9b4f48](https://github.com/apache/openwhisk/commit/f9b4f4841543ab27f4a7e974355802a811140483))
 is this used in the providers only now - if so i'm wondering if we can move it 
this code out.
   
   providers do not use getVCAPServicesFile(), but do use getVCAPcredentials()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to