rabbah commented on a change in pull request #4593: Change ContainerPool buffer 
processing 
URL: https://github.com/apache/openwhisk/pull/4593#discussion_r353034221
 
 

 ##########
 File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -199,10 +200,9 @@ class ContainerPool(childFactory: ActorRefFactory => 
ActorRef,
             }
             if (!isResentFromBuffer) {
               // Add this request to the buffer, as it is not there yet.
-              runBuffer = runBuffer.enqueue(r)
+              runBuffer = runBuffer.enqueue(Run(r.action, r.msg, 
retryLogDeadline))
             }
-            // As this request is the first one in the buffer, try again to 
execute it.
-            self ! Run(r.action, r.msg, retryLogDeadline)
+          //buffered items will be processed via processBufferOrFeed()
 
 Review comment:
   can you confirm my understanding that this change is sound because the 
request will still be in the process run buffer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to