rabbah commented on a change in pull request #4761: Add __OW_ACTION_VERSION in
action metadata
URL: https://github.com/apache/openwhisk/pull/4761#discussion_r353050946
##########
File path: tests/src/test/scala/actionContainers/BasicActionRunnerTests.scala
##########
@@ -309,6 +310,7 @@ trait BasicActionRunnerTests extends
ActionProxyContainerTestUtils {
"api_key" -> "abc",
"namespace" -> "zzz",
"action_name" -> "xxx",
+ "action_version" -> "0.0.1",
Review comment:
the tests in the runtimes will need to adapt for this change - for example:
https://github.com/apache/openwhisk-runtime-nodejs/blob/314cd92ea0c6681ba6455262f17fa9f5b777fbad/tests/src/test/scala/runtime/actionContainers/NodeJsActionContainerTests.scala#L75-L88
https://github.com/apache/openwhisk-runtime-php/blob/6cac63420c9bb1b9768c91d8cd384244a76fad2a/tests/src/test/scala/runtime/actionContainers/Php7ActionContainerTests.scala#L102-L119
https://github.com/apache/openwhisk-runtime-dotnet/blob/ef821d18ef6a96696bed521212333224575d8df6/tests/dotnetshared/Environment.cs#L24-L34
cc @shawnallen85 @akrabat @sciabarracom
We could make the check for this property optional as a way to transition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
