chetanmeh commented on a change in pull request #4768: Update kamon-core, 
instrumentations and reporters to 2.0.x.
URL: https://github.com/apache/openwhisk/pull/4768#discussion_r360772413
 
 

 ##########
 File path: 
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala
 ##########
 @@ -215,12 +215,12 @@ object Controller {
 
   def start(args: Array[String])(implicit actorSystem: ActorSystem, logger: 
Logging): Unit = {
     ConfigMXBean.register()
-    Kamon.loadReportersFromConfig()
+    Kamon.init()
 
 Review comment:
   Looks like a bug which was [recently fixed][1] (see 
kamon-io/kamon-prometheus#36). I see a [2.0.1 version of Prometheus 
reporter](https://gitter.im/kamon-io/Kamon?at=5dfcdb7d44e1fb33f6fc1cac) is now 
released with the fix
   
   [1]: https://github.com/kamon-io/Kamon/issues/566#issuecomment-567835368

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to