dubee commented on a change in pull request #364: Fix consumer dead state bug
URL:
https://github.com/apache/openwhisk-package-kafka/pull/364#discussion_r362669075
##########
File path: provider/service.py
##########
@@ -109,7 +104,20 @@ def run(self):
elif triggerIsAssignedToMe:
logging.info('[{}] Found a change to an
existing trigger'.format(change["id"]))
- if existingConsumer.desiredState() ==
Consumer.State.Disabled and self.__isTriggerDocActive(document):
+ if existingConsumer.desiredState() ==
Consumer.State.Dead and self.__isTriggerDocActive(document):
Review comment:
For background info, there is a nanny running periodically that deletes
consumers that are in a dead state. Since the consumer is already in a dead
state waiting for the nanny to close the process, a quick recreate of the
consumer -- within a 2 second time period -- will be ignored. Instead of
ignoring the recreate we will manually delete the consumer so that it can be
recreated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
