mcdan commented on a change in pull request #4804: Check to see if the user can
see the topic before creating it,
URL: https://github.com/apache/openwhisk/pull/4804#discussion_r370335825
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/connector/kafka/KafkaMessagingProvider.scala
##########
@@ -68,19 +68,25 @@ object KafkaMessagingProvider extends MessagingProvider {
val nt = new NewTopic(topic, partitions,
kafkaConfig.replicationFactor).configs(topicConfig.asJava)
def createTopic(retries: Int = 5): Try[Unit] = {
- Try(client.createTopics(List(nt).asJava).values().get(topic).get())
- .map(_ => logging.info(this, s"created topic $topic"))
- .recoverWith {
- case CausedBy(_: TopicExistsException) =>
- Success(logging.info(this, s"topic $topic already existed"))
- case CausedBy(t: RetriableException) if retries > 0 =>
- logging.warn(this, s"topic $topic could not be created because
of $t, retries left: $retries")
- Thread.sleep(1.second.toMillis)
- createTopic(retries - 1)
- case t =>
- logging.error(this, s"ensureTopic for $topic failed due to $t")
- Failure(t)
- }
+ Try(client.listTopics().names().get())
+ .map(topics =>
+ if (topics.contains(topic)) {
+ Success(logging.info(this, s"$topic already exists and the
user can see it, skipping creation."))
+ } else {
+
Try(client.createTopics(List(nt).asJava).values().get(topic).get())
Review comment:
If it's not there try and create it --- which will keep the same prior flow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
