rabbah commented on a change in pull request #121: A more backward compatible 
actionloop proxy
URL: 
https://github.com/apache/openwhisk-runtime-go/pull/121#discussion_r379593059
 
 

 ##########
 File path: openwhisk/actionProxy.go
 ##########
 @@ -72,6 +72,18 @@ func NewActionProxy(baseDir string, compiler string, 
outFile *os.File, errFile *
 
 //SetEnv sets the environment
 func (ap *ActionProxy) SetEnv(env map[string]interface{}) {
+       // Propagate proxy version
 
 Review comment:
   if the variables are the same between the proxy and the runtime, then you 
can just blindly export them. What's the rationale for renaming?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to