machenity commented on a change in pull request #198: Make cron triggers fire 
with random delay with parameter `strict`
URL: 
https://github.com/apache/openwhisk-package-alarms/pull/198#discussion_r388775421
 
 

 ##########
 File path: action/alarmWebAction.js
 ##########
 @@ -103,6 +103,7 @@ function main(params) {
                     }
                     newTrigger.cron = params.cron;
                     newTrigger.timezone = params.timezone;
+                    newTrigger.strict = params.strict === 'true';
 
 Review comment:
   First, thank you for finding my mistake. Then how about this?
   ```suggestion
                       newTrigger.strict = params.strict !== 'false';
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to