tysonnorris opened a new pull request #4938: URL: https://github.com/apache/openwhisk/pull/4938
<!--- Provide a concise summary of your changes in the Title --> ## Description Currently there are some cases that are not handled in ContainerProxy for concurrent activation processing: With multiple in flight, if one fails, ContainerProxy may stop immediately, causing dead letters and forced ack at controller. Failures may look slightly different depending on how the action fails: * intermittent failures behave one way (some success, some, failures at response of POST /run to action container - e.g. sometimes return an empty promise from action) * terminal failures behave a different way (e.g. nodejs process crashes in action container a la `process.exit()`) To handle these, ContainerProxy needs to check `activeCount` tracking variable to determine if any addition activations are in-flight when an error occurs, and behave accordingly. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
