bdoyle0182 opened a new pull request #4941: URL: https://github.com/apache/openwhisk/pull/4941
## Description Adds a force parameter to the delete package api so any actions in the package are deleted with it before confirming and deleting the package. If force is not set (by default), it still returns the same error of needing to delete the actions first before deleting the package. I could use some help on optimizing the package deletion because currently I need to do a get action list to get the list of actions in the package, and then I have to do a get on the actions to get the revision id before I can delete the action. Any advice here would be appreciated because of my lack of familiarity with the code. It does work as is though currently. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [x] I opened an issue to propose and discuss this change (#1824) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [x] API - [x] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [x] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
