ningyougang commented on a change in pull request #4940:
URL: https://github.com/apache/openwhisk/pull/4940#discussion_r472056331
##########
File path: core/controller/src/main/resources/apiv1swagger.json
##########
@@ -1910,6 +1910,13 @@
},
"description": "annotations on the item"
},
+ "delAnnotations": {
+ "type": "array",
+ "items": {
+ "type": "string"
+ },
+ "description": "del annotations on the item"
Review comment:
Updated accordingly
##########
File path: tests/src/test/scala/system/basic/WskActionTests.scala
##########
@@ -357,4 +357,39 @@ class WskActionTests extends TestHelpers with
WskTestHelpers with JsHelpers with
}
}
+ it should "not delete previous annotation when update action with new
annotation" in withAssetCleaner(wskprops) {
Review comment:
Updated accordingly
##########
File path:
tests/src/test/scala/org/apache/openwhisk/core/cli/test/WskRestBasicUsageTests.scala
##########
@@ -131,6 +131,38 @@ class WskRestBasicUsageTests extends TestHelpers with
WskTestHelpers with WskAct
}
}
+ it should "update an action via passing delAnnotations" in
withAssetCleaner(wskprops) { (wp, assetHelper) =>
Review comment:
Updated accordingly
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala
##########
@@ -537,6 +537,14 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
val exec = content.exec getOrElse action.exec
+ var newAnnotations = action.annotations
Review comment:
Updated accordingly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
