mrutkows commented on a change in pull request #1100:
URL:
https://github.com/apache/openwhisk-wskdeploy/pull/1100#discussion_r472423913
##########
File path: parsers/manifest_parser.go
##########
@@ -29,6 +29,8 @@ import (
"gopkg.in/yaml.v2"
+ "net/url"
Review comment:
better ordering of dependencies
##########
File path: parsers/manifest_parser.go
##########
@@ -796,7 +797,7 @@ func (dm *YAMLParser) composeActionExec(manifestFilePath
string, manifestFileNam
if action.Native {
exec.Image = NATIVE_DOCKER_IMAGE
} else {
- exec.Image = action.Docker
+ exec.Image =
wskenv.InterpolateStringWithEnvVar(action.Docker).(string)
Review comment:
Interpolation feature in 1 line! Nice!
##########
File path: parsers/manifest_parser_test.go
##########
@@ -960,8 +960,15 @@ func TestComposeActionsForDocker(t *testing.T) {
assert.NotNil(t, action.Action.Exec.Code,
TEST_MSG_ACTION_CODE_MISSING)
assert.Equal(t, runtimes.BLACKBOX,
action.Action.Exec.Kind, fmt.Sprintf(TEST_MSG_ACTION_DOCKER_KIND_MISMATCH,
action.Action.Exec.Kind))
assert.Equal(t, "mydockerhub/myimage",
action.Action.Exec.Image, TEST_MSG_ACTION_DOCKER_IMAGE_MISMATCH)
+ case "CustomDockerAction6":
Review comment:
Thanks for adding a unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
