tysonnorris opened a new pull request #4958: URL: https://github.com/apache/openwhisk/pull/4958
This is a sister to #4938 to improve failure handling cases for: - concurrency enabled actions - cold start container failures <!--- Provide a concise summary of your changes in the Title --> ## Description In a previous PR #4938 we changed the behavior where - concurrency enabled actions - init failure occurs so that any queued activations at the ContainerProxy (because the action supports concurrency), will be aborted if /init fails. This PR, extends that same behavior to the case where cold start of a container fails. In both cases (/init fails, cold start for the container fails), we assume that a failure will not resolve by retry of the activation(s). That won't always be true (a transient issue with docker registry), but in our experience it usually true (an invalid image, or inability to launch containers for some longer amount of time than will be resolved in 60s). ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
