style95 commented on a change in pull request #4984: URL: https://github.com/apache/openwhisk/pull/4984#discussion_r494717183
########## File path: core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/NoopDurationChecker.scala ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.openwhisk.core.scheduler.queue + +import akka.actor.ActorSystem +import org.apache.openwhisk.common.Logging +import org.apache.openwhisk.core.entity.WhiskActionMetaData + +import scala.concurrent.Future + +object NoopDurationCheckerProvider extends DurationCheckerProvider { Review comment: This is just for other DBs such as CouchDB or CosmosDB in case the scheduler is used with other than ES. (Even if it is highly recommended to use with ES.) Regarding the average duration, it is important to improve the accuracy of calculation but the queue can still work without it. When an action is newly created, there is no activation accordingly no average duration. In such a case, it assumes one container can handle one activation for the given time. So even if one container can handle multiple activations for a given period, it assumes a container can handle only one activation, so schedulers would tend to overprovision containers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
