bdoyle0182 commented on a change in pull request #4983: URL: https://github.com/apache/openwhisk/pull/4983#discussion_r496451072
########## File path: core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/SchedulerServer.scala ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.openwhisk.core.scheduler + +import akka.actor.ActorSystem +import akka.http.scaladsl.model.StatusCodes +import akka.http.scaladsl.model.headers.BasicHttpCredentials +import akka.http.scaladsl.server.Route +import org.apache.openwhisk.common.{Logging, TransactionId} +import org.apache.openwhisk.http.BasicRasService +import org.apache.openwhisk.http.ErrorResponse.terminate +import spray.json._ + +import scala.concurrent.ExecutionContext + +/** + * Implements web server to handle certain REST API calls. + * Currently provides a health ping route, only. + */ +class SchedulerServer(scheduler: SchedulerCore, systemUsername: String, systemPassword: String)( + implicit val ec: ExecutionContext, + implicit val actorSystem: ActorSystem, + implicit val logger: Logging) + extends BasicRasService { + + override def routes(implicit transid: TransactionId): Route = { + super.routes ~ extractCredentials { + case Some(BasicHttpCredentials(username, password)) if username == systemUsername && password == systemPassword => + (path("disable") & post) { Review comment: Can we rename the route to `shutdown`? `disable` I associate more with temporarily turning off the resource but not stopping the entire service. not a big deal if you want to leave it as is ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
