rabbah commented on a change in pull request #4855:
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r505093998
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala
##########
@@ -57,6 +57,7 @@ case class ActivationMessage(override val transid:
TransactionId,
blocking: Boolean,
content: Option[JsObject],
initArgs: Set[String] = Set.empty,
+ lockedArgs: Map[String, String] = Map.empty,
Review comment:
We can also revert this PR and merge it after 1.0.
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala
##########
@@ -57,6 +57,7 @@ case class ActivationMessage(override val transid:
TransactionId,
blocking: Boolean,
content: Option[JsObject],
initArgs: Set[String] = Set.empty,
+ lockedArgs: Map[String, String] = Map.empty,
Review comment:
That's OK but perhaps not necessary? I think your concern is rolling
updates. If the controller is updated first it serializes the message but the
invoker deserializes it without the locked args field. If you update the
invokers first, they can accept these messages but the controller doesn't send
any. If there are no encrypted args, the map is empty anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
