rabbah commented on a change in pull request #480:
URL: https://github.com/apache/openwhisk-cli/pull/480#discussion_r553399183
##########
File path: commands/action.go
##########
@@ -849,49 +854,76 @@ func getWebSecureAnnotations(action *whisk.Action)
whisk.KeyValueArr {
return webKvArr[0:j]
}
+func getNewSecret(secret interface{}) string {
+ _, isJSONNum := secret.(json.Number)
Review comment:
I'd replace this with the ability to generate an alphanumeric secret
instead.
Something like:
```go
rand.Seed(time.Now().UnixNano())
var alphabet = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
b := make([]rune, SECRET_LENGTH)
for i := range b {
b[i] = alphabet[rand.Intn(len(alphabet))]
}
return string(b)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
