KeonHee commented on a change in pull request #5031:
URL: https://github.com/apache/openwhisk/pull/5031#discussion_r570669969
##########
File path: ansible/roles/controller/tasks/deploy.yml
##########
@@ -272,6 +272,11 @@
"CONFIG_whisk_controller_activation_pollingFromDb": "{{
controller_activation_pollingFromDb | default(true) | lower }}"
+ "CONFIG_whisk_etcd_hosts": "{{ etcd_connect_string }}"
Review comment:
In the case of configuration, it would be good to add only what is
needed when etcd is used in the controller & invoker. I will exclude it from
this PR.
##########
File path: tests/build.gradle
##########
@@ -73,10 +73,11 @@ ext.testSets = [
"org/apache/openwhisk/core/cli/test/**",
"org/apache/openwhisk/core/limits/**",
"org/apache/openwhisk/core/scheduler/queue/test/ElasticSearchDurationCheck*",
+ "org/apache/openwhisk/common/etcd/**",
Review comment:
Excluded etcd from basic unit tests.
##########
File path: tests/build.gradle
##########
@@ -197,6 +198,14 @@ task testUnit(type: Test) {
exclude couchDbExcludes
}
+task testUnitEtcd(type: Test) {
Review comment:
The etcd test can be run with `./gradlew tests:testUnitEtcd`.
##########
File path: tests/build.gradle
##########
@@ -73,10 +73,11 @@ ext.testSets = [
"org/apache/openwhisk/core/cli/test/**",
"org/apache/openwhisk/core/limits/**",
"org/apache/openwhisk/core/scheduler/queue/test/ElasticSearchDurationCheck*",
+ "org/apache/openwhisk/common/etcd/**",
Review comment:
Yes. One concern is that if the test is excluded, the code is merged
without going through the CI test, so I would like to see if the CI also needs
a pipeline for the scheduler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
