style95 commented on a change in pull request #5061:
URL: https://github.com/apache/openwhisk/pull/5061#discussion_r570661010
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/service/DataManagementService.scala
##########
@@ -0,0 +1,6 @@
+package org.apache.openwhisk.core.service
+
+case class UpdateDataOnChange(key: String, value: String)
+
+// TODO, all operations for etcd via DataManagementService
Review comment:
I hope this PR is rebased after this kind of module is landed according
to this plan:
https://cwiki.apache.org/confluence/display/OPENWHISK/Component+Design
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala
##########
@@ -440,34 +440,6 @@ case class InvokerResourceMessage(status: String,
* Serializes message to string. Must be idempotent.
*/
override def serialize: String =
InvokerResourceMessage.serdes.write(this).compactPrint
-
- def canEqual(a: Any) = a.isInstanceOf[InvokerResourceMessage]
-
- override def equals(that: Any): Boolean =
- that match {
- case that: InvokerResourceMessage => {
- that.canEqual(this) &&
- this.status == that.status &&
- this.freeMemory == that.freeMemory &&
- this.busyMemory == that.busyMemory &&
- this.inProgressMemory == that.inProgressMemory &&
- this.tags.toSet == that.tags.toSet
- this.dedicatedNamespaces.toSet == that.dedicatedNamespaces.toSet
- }
- case _ => false
- }
-
- override def hashCode: Int = {
Review comment:
@ningyougang
IIRC, we introduced this not to store data to ETCD if the data is the same
as the previous one.
Can we make sure this requirement with the default comparison functionality
provided by the case class?
I am not quite sure but we were using this class without these methods but
introduced them at some point for some reason.
Could you confirm once?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
