ningyougang commented on pull request #5061:
URL: https://github.com/apache/openwhisk/pull/5061#issuecomment-789351618


   @bdoyle0182 
   
   > I think this generally looks good to me. But I think I need to see the the 
upstream DataManagementService this is forwarding message to and possibly the 
new downstream ContainerProxy that I believe is requesting activations by 
sending a message to this fsm?
   
   Sorry, i don't understand what you mean. i tried to share like below
   This is the DataManagementService pr: 
https://github.com/apache/openwhisk/pull/5063, store data to etcd with lease / 
delete data from etcd.  invokerHealthyManager will use DataManagementService  
to store its healthy data to etcd,  e.g. dataManagementService ! 
UpdateDataOnChange(InvokerKeys.health(instanceId), 
invokerResourceMessage.serialize)
   
   
   > So is my understanding correct that every invoker will have a healthcheck 
container running at all times? What is the gap between requesting healthcheck 
activations from this fsm from the container or is it just always trying to run 
the healthcheck code with no gaps?
   
   InvokerHealthyManager doesn't have a healthcheck container running at all 
time, it will create a healthcheck container at the very beginning or when the 
healthy status's changed from Healthy to Unhealthy, for the activation request 
for the healthcheck container,  it will fetch the local activation, e.g.
   
![image](https://user-images.githubusercontent.com/11749867/109737890-d1b45500-7c01-11eb-8ba7-0100db62a0bd.png)
   BTW, for the other action container, it will fetch activation from scheduler 
component's memoryQueue using grpc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to