style95 commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638378157
##########
File path: ansible/roles/controller/tasks/deploy.yml
##########
@@ -292,6 +292,19 @@
env: "{{ env | combine(elastic_env) }}"
when: db.activation_store.backend == "ElasticSearch"
+- name: setup mongodb artifact store env
+ set_fact:
+ mongodb_env:
+ "CONFIG_whisk_mongodb_uri": "{{ db.mongodb.connect_string }}"
+ "CONFIG_whisk_mongodb_database": "{{ db.mongodb.database }}"
+ "CONFIG_whisk_spi_ArtifactStoreProvider":
"org.apache.openwhisk.core.database.mongodb.MongoDBArtifactStoreProvider"
+ when: db.backend == "MongoDB"
Review comment:
I meant we need a consolidated way to configure multiple DBs for each
entity store as we have more options for them.
For example, we might consider the following option:
1. Use the database for all entities if only `db.backend` is defined.
2. Use a different database for activation if `db.activation_store.backend`
is defined along with `db.backend`.
3. Use a different database for whisk entities if
`db.artifact_store.backend` is defined along with `db.backend`.
.
.
.
if no specific backend store is defined, we can fall back to `db.backend` by
default.
We can have fine granularity but I feel like having two configurations for
activations and the others would be enough for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
