jiangpengcheng commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638594384
##########
File path: ansible/roles/controller/tasks/deploy.yml
##########
@@ -292,6 +292,19 @@
env: "{{ env | combine(elastic_env) }}"
when: db.activation_store.backend == "ElasticSearch"
+- name: setup mongodb artifact store env
+ set_fact:
+ mongodb_env:
+ "CONFIG_whisk_mongodb_uri": "{{ db.mongodb.connect_string }}"
+ "CONFIG_whisk_mongodb_database": "{{ db.mongodb.database }}"
+ "CONFIG_whisk_spi_ArtifactStoreProvider":
"org.apache.openwhisk.core.database.mongodb.MongoDBArtifactStoreProvider"
+ when: db.backend == "MongoDB"
Review comment:
I think `activation` is a kind of `artifact`? so
`db.artifact_store.backend` should refer to all kind of entities including
`activation`, which is just like what `db.backend` do here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
