shawnallen85 commented on pull request #61: URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/61#issuecomment-1003668997
I was able to clone your repo and run the tests locally -- there are a number of errors that need to be resolved. I like going forward with using System.Text.Json rather than Json.NET to remove the additional dependency and it'll *finally* resolve https://github.com/apache/openwhisk-runtime-dotnet/issues/51. I've been holding off on making that change for a new LTS runtime to be released. I think it would be worth adding some additional wording to state that migration and link to (or provide details on) porting existing functions over. To get the test running locally, could you give this a try? In a **new** directory ... ```bash git clone [email protected]:apache/openwhisk.git cd openwhisk export OPENWHISK_HOME=`pwd` cd .. git clone [email protected]:paul42/openwhisk-runtime-dotnet.git cd openwhisk-runtime-dotnet pushd $OPENWHISK_HOME ./gradlew install podd $OPENWHISK_HOME ./gradlew :tests:test --tests DotNet6_0ActionContainerTests ``` It might make sense to pull back on some of the refactoring and use the `3.1` codebase as a guide and update things as described by [Microsoft on upgrading projects](https://docs.microsoft.com/en-us/aspnet/core/migration/31-to-60?view=aspnetcore-6.0&tabs=visual-studio). LKM if this is asking a lot, I've been meaning to dive into this code and get things updated for the new runtime. Thanks!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
