bdoyle0182 commented on pull request #5205: URL: https://github.com/apache/openwhisk/pull/5205#issuecomment-1077805807
The active acks would continue to still be sent back to the controller until there's no activations left to process off of kafka. This is where it's not perfect since you would configure a sleep time between disabling the invoker and then shutting it down. You may also not want to shut down but stop processing on that invoker to debug some issue. `InvokerSupervision` in the controller will transition to `Offline` and stay in that state until it gets another ping back even if it continues to get completion messages. Dominic did bring up a good point that I could add a `disabled` boolean field to the Ping message and send that as a final message on the health topic so the controller sees immediately that it is disabled to transition to `Offline` rather than waiting up to 10 seconds (the hardcoded time in `InvokerSupervision` to transition to `Offline` if no ping has been received -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
