dylanturn commented on code in PR #5210:
URL: https://github.com/apache/openwhisk/pull/5210#discussion_r843952664
##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
compile "io.reactivex:rxjava:1.3.8"
compile "io.reactivex:rxjava-reactive-streams:1.2.1"
compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+ compile
"com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"
Review Comment:
> I didn't look into it deeply but from a certain version of ES-7.x they
would no longer support it with the Apache license.
What wouldn't they support? Elastic changed the license model sometime after
7.10.x, so this is still entirely covered Apache 2.0.
It's also worth mentioning we don't _have_ to use Elasticsearch. This update
makes it possible to use Opensearch, which is covered entirely by Apache 2.0.
##########
common/scala/build.gradle:
##########
@@ -89,8 +89,8 @@ dependencies {
compile "io.reactivex:rxjava:1.3.8"
compile "io.reactivex:rxjava-reactive-streams:1.2.1"
compile "com.microsoft.azure:azure-cosmosdb:2.6.2"
+ compile
"com.sksamuel.elastic4s:elastic4s-client-esjava_${gradle.scala.depVersion}:7.10.3"
Review Comment:
> I didn't look into it deeply but from a certain version of ES-7.x they
would no longer support it with the Apache license.
What wouldn't they support? Elastic changed the license model sometime after
7.10.x, so this is still entirely covered Apache 2.0.
It's also worth mentioning we don't _have_ to use Elasticsearch. This update
makes it possible to use Opensearch, which is covered entirely by Apache 2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
