style95 commented on code in PR #5276:
URL: https://github.com/apache/openwhisk/pull/5276#discussion_r926190664
##########
core/standalone/build.gradle:
##########
@@ -157,17 +157,19 @@ gitProperties {
install.dependsOn(bootJar)
dependencies {
- compile "org.scala-lang:scala-library:${gradle.scala.version}"
- compile project(':core:controller')
- compile project(':tools:admin')
- compile "org.rogach:scallop_${gradle.scala.depVersion}:3.3.2"
-
- compile
"io.github.embeddedkafka:embedded-kafka_${gradle.scala.depVersion}:2.4.0"
- compile "org.scala-lang:scala-reflect:${gradle.scala.version}"
- compile "ch.megard:akka-http-cors_${gradle.scala.depVersion}:0.4.2"
-
- testCompile "junit:junit:4.11"
- testCompile "org.scalatest:scalatest_${gradle.scala.depVersion}:3.0.8"
+ implementation "org.scala-lang:scala-library:${gradle.scala.version}"
+ implementation project(':common:scala')
Review Comment:
So we need to explicitly add all dependencies with `implementation`?
##########
core/invoker/build.gradle:
##########
@@ -32,17 +32,16 @@ ext.coverageDirs = [
"${buildDir}/classes/scala/scoverage",
"${project(':common:scala').buildDir.absolutePath}/classes/scala/scoverage"
]
-distDockerCoverage.dependsOn ':common:scala:scoverageClasses',
'scoverageClasses'
Review Comment:
How is this `dependsOn` handled now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
