ningyougang commented on code in PR #5244: URL: https://github.com/apache/openwhisk/pull/5244#discussion_r929537243
########## proposals/POEM-support-array-result.md: ########## @@ -0,0 +1,70 @@ +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> +# Title + +Currently, openwhisk supports return json object only, e.g. +```shell +# wsk action invoke hello -r +{ + "greeting": "Hello stranger!" +} +``` +It is necessary to support return array for common action, e.g. +```shell +# wsk action invoke hello-array -r +[ + "a", + "b" +] +``` +For sequence action, need to support as well. + +# Status +* Current state: In-progress +* Author(s): @ningyougang + +# Summary and Motivation + +This POEM proposes a new feature that allows user to write their own action which supports array result. +So the result will support object and array both in future. Review Comment: Updated accordingly ########## proposals/POEM-support-array-result.md: ########## @@ -0,0 +1,70 @@ +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> +# Title + +Currently, openwhisk supports return json object only, e.g. +```shell +# wsk action invoke hello -r +{ + "greeting": "Hello stranger!" +} +``` +It is necessary to support return array for common action, e.g. +```shell +# wsk action invoke hello-array -r +[ + "a", + "b" +] +``` +For sequence action, need to support as well. + +# Status +* Current state: In-progress +* Author(s): @ningyougang + +# Summary and Motivation + +This POEM proposes a new feature that allows user to write their own action which supports array result. +So the result will support object and array both in future. + +# Proposed changes +## Openwhisk main repo +Make controller and invoker support array result both. + +## Runtime repos +All runtime images should support array result. e.g. Review Comment: Updated accordingly ########## proposals/POEM-support-array-result.md: ########## @@ -0,0 +1,70 @@ +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> +# Title + +Currently, openwhisk supports return json object only, e.g. +```shell +# wsk action invoke hello -r +{ + "greeting": "Hello stranger!" +} +``` +It is necessary to support return array for common action, e.g. +```shell +# wsk action invoke hello-array -r +[ + "a", + "b" +] +``` +For sequence action, need to support as well. + +# Status +* Current state: In-progress +* Author(s): @ningyougang + +# Summary and Motivation + +This POEM proposes a new feature that allows user to write their own action which supports array result. +So the result will support object and array both in future. + +# Proposed changes +## Openwhisk main repo +Make controller and invoker support array result both. + +## Runtime repos +All runtime images should support array result. e.g. + +* nodejs (supports by default) +* go +* java +* python +* php +* shell +* docker +* ruby +* dotnet +* rust +* swift +* deno +* ballerina + +## Openwhisk-cli repo +* When use wsk to execute action, need to support parse array result. Review Comment: Updated accordingly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
