[GitHub] [openwhisk] style95 opened a new pull request, #5300: Revert cycle handling.

[GitBox]

style95 opened a new pull request, #5300:
URL: https://github.com/apache/openwhisk/pull/5300

   
   ## Description
   This is to revert the recent change.
   https://github.com/apache/openwhisk/pull/5251 is introduced to handle the 
cyclic activations in a queue manager.
   But with this change, I observed severe performance degradation.
   
   This is the performance measurement with the current master.
   <img width="1217" alt="image" 
src="https://user-images.githubusercontent.com/3447251/182029788-eff06df6-a2a9-495a-b0d4-1aa578827037.png";>
   
   And this is the result of this change.
   <img width="1226" alt="image" 
src="https://user-images.githubusercontent.com/3447251/182029821-5f38b4b2-9cff-4591-a87a-a21fc015f185.png";>
   
   This is because even for normal activations, the queue manager tries to 
recover a queue.
   There is a gap between the time that leader election is done(etcd data is 
written) and the queue is ready.
   If activations come during that time, the queue manager tries to recover a 
queue and it increases the duration.
   
   And the result is well aligned with the one I performed for the initial run.
   https://github.com/apache/openwhisk/pull/5194#issuecomment-1019875232
   
   Since the cycle in a critical path is also a big problem, we must handle it.
   But until we find a better way to address it I think it would be better to 
revert this change.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Scheduler
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the 
boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered 
all aspects of the change you're making. -->
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org