style95 commented on code in PR #5302:
URL: https://github.com/apache/openwhisk/pull/5302#discussion_r935100327
##########
ansible/group_vars/all:
##########
@@ -530,9 +530,9 @@ scheduler:
maxRetriesToGetQueue: "{{ scheduler_maxRetriesToGetQueue | default(13) }}"
queue:
# the queue's state Running timeout, e.g. if have no activation comes into
queue when Running, the queue state will be changed from Running to Idle and
delete the decision algorithm actor
- idleGrace: "{{ scheduler_queue_idleGrace | default('20 seconds') }}"
+ idleGrace: "{{ scheduler_queue_idleGrace | default('10 minutes') }}"
Review Comment:
As warmed containers are kept for 10 minutes, it's better to keep the queue
as well.
It's relatively safer than containers to keep an idle queue as it uses fewer
resources when idle.
##########
core/invoker/src/main/resources/application.conf:
##########
@@ -180,6 +180,13 @@ whisk {
username: "invoker.user"
password: "invoker.pass"
protocol: http
+
+ resource {
Review Comment:
These are required to run OpenWhisk with other than Ansible.
##########
ansible/roles/schedulers/tasks/deploy.yml:
##########
@@ -187,6 +187,10 @@
"CONFIG_whisk_timeLimit_max": "{{ limit_action_time_max | default() }}"
"CONFIG_whisk_timeLimit_std": "{{ limit_action_time_std | default() }}"
+ "CONFIG_whisk_concurrencyLimit_min": "{{ limit_action_concurrency_min |
default() }}"
Review Comment:
It is missing configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
