ningyougang commented on code in PR #170: URL: https://github.com/apache/openwhisk-runtime-go/pull/170#discussion_r936197673
########## golang1.17/Dockerfile: ########## @@ -38,7 +38,7 @@ RUN echo "deb http://deb.debian.org/debian buster-backports main contrib non-fre librdkafka-dev=0.11.6-1.1 &&\ # Cleanup apt data, we do not need them later on. apt-get clean && rm -rf /var/lib/apt/lists/* &&\ - go get -u github.com/go-delve/delve/cmd/[email protected] &&\ + go install github.com/go-delve/delve/cmd/[email protected] &&\ Review Comment: Fix issue ``` go get: installing executables with 'go get' in module mode is deprecated. Use 'go install pkg@version' instead. For more information, see https://golang.org/doc/go-get-install-deprecation or run 'go help get' or 'go help install'. # github.com/rivo/uniseg pkg/mod/github.com/rivo/[email protected]/properties.go:130:6: missing function body pkg/mod/github.com/rivo/[email protected]/properties.go:130:20: syntax error: unexpected [, expecting ( note: module requires Go 1.18 ``` ########## build.gradle: ########## @@ -18,6 +18,7 @@ buildscript { repositories { jcenter() + mavenCentral() Review Comment: Fix  `scalafmt-core` is deprecated in jcenter, should use `mavenCentral()` And need to keep jcenter() due to exist some lib needs this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
