ningyougang commented on code in PR #140: URL: https://github.com/apache/openwhisk-runtime-java/pull/140#discussion_r939487592
########## core/java8actionloop/Dockerfile: ########## @@ -31,13 +31,13 @@ RUN curl -sL \ https://github.com/apache/openwhisk-runtime-go/archive/{$GO_PROXY_RELEASE_VERSION}.tar.gz\ | tar xzf -\ && cd openwhisk-runtime-go-*/main\ - && GO111MODULE=on go build -o /bin/proxy + && GO111MODULE=on CGO_ENABLED=0 go build -o /bin/proxy # Use AdoptOpenJDK's JDK8, OpenJ9, ubuntu FROM ibm-semeru-runtimes:open-8u332-b09-jdk-focal # select the builder to use -ARG GO_PROXY_BUILD_FROM=release +ARG GO_PROXY_BUILD_FROM=source Review Comment: @style95 seems change GO_PROXY_BUILD_FROM to `source` is not better, but in order to support array result, must use go runtime's upstream master code. Can we release a new version for go runtime? e.g. https://github.com/apache/openwhisk-runtime-java/blob/master/core/java8actionloop/Dockerfile#L29 Change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
