ningyougang commented on code in PR #517:
URL: https://github.com/apache/openwhisk-cli/pull/517#discussion_r957031960
##########
settings.gradle:
##########
@@ -25,10 +25,14 @@ gradle.ext.openwhisk = [
gradle.ext.scala = [
version: '2.12.7',
- compileFlags: ['-feature', '-unchecked', '-deprecation',
'-Xfatal-warnings', '-Ywarn-unused-import']
+ depVersion : '2.12',
+ compileFlags: ['-feature', '-unchecked', '-deprecation',
'-Ywarn-unused-import']
Review Comment:
Due to deprecated issue, i tried to upgrade SSL lib, but
`WskCliActivationTests` test case still failed with upgraded lib, and i didn't
solve it for long time :(
In orde to make `./gradlew --console=plain :tests:test
--tests="system.basic.WskCliActivationTests"` test case passed and make this pr
merged, i removed `'-Xfatal-warnings'` in this pr. (Fyi, `-Xfatal-warnings`
means `warnings as errors` )
But normally, should keep `'-Xfatal-warnings'` , so i created a issue here:
https://github.com/apache/openwhisk-cli/issues/518, we can add
`'-Xfatal-warnings'` back and upgrade SSL lib to make `WskCliActivationTests`
passed in another separate pr
I think other upstream guys can open pr to solve it as well. i didn't solve
it in my local.
Btw, only need to modify below method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
