bdoyle0182 commented on code in PR #5320:
URL: https://github.com/apache/openwhisk/pull/5320#discussion_r959211216
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala:
##########
@@ -144,6 +144,11 @@ class ContainerManager(jobManagerFactory: ActorRefFactory
=> ActorRef,
logging.info(this, s"received ${msgs.size} creation message
[${msgs.head.invocationNamespace}:${msgs.head.action}]")
ContainerManager
.getAvailableInvokers(etcdClient, memory, invocationNamespace)
+ .recover({
+ case t: Throwable =>
+ logging.error(this, s"Unable to get available invokers:
${t.getMessage}.")
+ List.empty[InvokerHealth]
+ })
Review Comment:
One solution could be to make the request from `MemoryQueue` to
`ContainerManager` an ask rather than a tell and make the timeout of the ask
the value of `CONFIG_whisk_scheduler_inProgressJobRetention` plus one second
for buffer. That would probably significantly reduce the complexity of the
MemoryQueue as well for message cases you need to account for
(I think the `CreationJobManager` actually gets the responsibility of
responding to the `MemoryQueue` in most cases, but you should be able to just
forward the ref of the ask as a param to `CreationJobManager` from
`ContainerManager`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
